[webkit-reviews] review requested: [Bug 50521] [Qt] Improper rendering of <button> tag when it contains a <br> : [Attachment 82989] proposed patch...

[bugzilla-daemon at webkit.org]

Dawit A. <adawit at kde.org> has asked  for review:
Bug 50521: [Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

Attachment 82989: proposed patch...
https://bugs.webkit.org/attachment.cgi?id=82989&action=review

------- Additional Comments from Dawit A. <adawit at kde.org>
Do not hard code the width/height of the render style in
RenderThemeQt::computeSizeBasedOnStyle. Instead set the calculated values as
minimum width and height values.

Set the original values of the bottom and top margin variables in
RenderThemeQt::setButtonPadding to the same value as the right and left ones.
No idea why one is set to 1 and the other to 0.

No idea what kind of impact this has on the mobile platforms with their
qt_mobile_theme, but these changes definitely fix the problem with multi-line
text buttons on Linux desktops.