[webkit-reviews] review granted: [Bug 54726] use actual browser focus in the code review tool : [Attachment 82927] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 11:37:53 PST 2011


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 54726: use actual browser focus in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54726

Attachment 82927: Patch
https://bugs.webkit.org/attachment.cgi?id=82927&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82927&action=review

> Websites/bugs.webkit.org/code-review.js:1342
> +    // Give a tabindex so the element can receive actual browser focus.
> +    // -1 makes the element focusable without actually putting in in the tab
order.
> +    node.attr('tabindex', -1);

Crazy!


More information about the webkit-reviews mailing list