[webkit-reviews] review canceled: [Bug 51339] [Qt] Redesign the build system : [Attachment 82486] patch part2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 08:15:44 PST 2011


Andras Becsi <abecsi at webkit.org> has canceled Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 51339: [Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Attachment 82486: patch part2
https://bugs.webkit.org/attachment.cgi?id=82486&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
I finally managed to also move the WebKit2 API to the final step, and moved
bridge and bindings back to WebCore.pro as Laszlo suggested.

WebKit2/WebProcess/qt/WebProcessMainQt.cpp had to be moved to the final step as
well, so the WK2 and JSC library don't need whole-archive any more.

In theory later changes could introduce trouble with the clashing filenames of
WebCore and WebKit2 (especially with header includes), but this risk is minimal
since only the API is in the final step.

This patch should make it possible to also work on the Windows version of Qt
WebKit2.

This most certainly needs a clean build.


More information about the webkit-reviews mailing list