[webkit-reviews] review denied: [Bug 54671] Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit : [Attachment 82948] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 54671: Web Inspector: provide a button to expand inspector toolbar when not
all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671

Attachment 82948: patch
https://bugs.webkit.org/attachment.cgi?id=82948&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82948&action=review

> Source/WebCore/inspector/front-end/ToolbarDropdown.js:31
> +WebInspector.ToolbarDropdown = function()

I think you should extract toobar component from inspector.js, not make it
involved with dropdown in addition to the toolbar internals.

> Source/WebCore/inspector/front-end/ToolbarDropdown.js:77
> +		   var clone = toolbarElement.cloneNode(true);

I don't think you should clone node here, it would be more intuitive to simply
reuse toolbar button creation code.