[webkit-reviews] review canceled: [Bug 54451] FESpecularLightingElement changes doesn't require relayout. : [Attachment 82784] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 18 06:06:48 PST 2011
Renata Hodovan <reni at webkit.org> has canceled Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 54451: FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451
Attachment 82784: Patch
https://bugs.webkit.org/attachment.cgi?id=82784&action=review
------- Additional Comments from Renata Hodovan <reni at webkit.org>
> Hm, what do you mean with different offset? a specularLighting or
diffuseLigthning element should just have the 3 LightElements as child. So the
structure is the same?
> I'd combine the two methods in a function:
The common functions are moved into the LightElement class, but i couldn't
merge the two methods 'cause there are used different places without reference
to each other.
More information about the webkit-reviews
mailing list