[webkit-reviews] review denied: [Bug 54308] Always display the media controls when requiresFullscreenForVideoPlayback() is true : [Attachment 82165] first draft

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 54308: Always display the media controls when
requiresFullscreenForVideoPlayback() is true
https://bugs.webkit.org/show_bug.cgi?id=54308

Attachment 82165: first draft
https://bugs.webkit.org/attachment.cgi?id=82165&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82165&action=review

> Source/WebCore/html/shadow/MediaControls.cpp:126
> +    if ((!media->controls() &&
!m_mediaElement->document()->page()->chrome()->requiresFullscreenForVideoPlayba
ck()) || !media->inActiveDocument()) {

This logic should be in HTMLMediaElement::controls()