[webkit-reviews] review granted: [Bug 54741] [Qt] Regression : on www.gmail.com a strange rendering issue appears on the menu bar due to flash. : [Attachment 82945] Patch to fix the plugin rendering issues.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 54741: [Qt] Regression : on www.gmail.com a strange rendering issue appears
on the menu bar due to flash.
https://bugs.webkit.org/show_bug.cgi?id=54741

Attachment 82945: Patch to fix the plugin rendering issues.
https://bugs.webkit.org/attachment.cgi?id=82945&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82945&action=review

r=me, but my inner kenneth has some complaints :)

> Source/WebCore/ChangeLog:5
> +	   [Qt] Regression : on www.gmail.com a strange rendering issue appears
on the

If you know which commit caused the regression, we typically put something like
"REGRESSION(r12345): Bla bla bla."

> Source/WebCore/ChangeLog:6
> +	    menu bar due to flash.

<kenneth>Extra space before "menu"!</kenneth>

> Source/WebCore/ChangeLog:10
> +	   Only show plugins with a valid size. We then avoid X in the game if
there is
> +	   nothing to see anyway.

s/X/involving X11/ for clarity.

> Source/WebCore/plugins/qt/PluginViewQt.cpp:144
> +    // The plugin had a zero width or height before but was resized, we need
to show it again

<kenneth>Needs period at end of sentence.</kenneth>

> Source/WebCore/plugins/qt/PluginViewQt.cpp:949
> +    // If the width and the height are not zero we show the pluginView

<kenneth>Needs period at end of sentence.</kenneth>
Also, s/pluginView/PluginView/