[webkit-reviews] review denied: [Bug 54724] Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect start/end of selection for RTL : [Attachment 82925] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 54724: Extending selection by a boundary granularity
(LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect start/end of
selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724

Attachment 82925: Patch
https://bugs.webkit.org/attachment.cgi?id=82925&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82925&action=review

> Source/WebCore/ChangeLog:8
> +	   Extending selection by a boundary granularity
(LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect start/end of
selection for RTL
> +	   https://bugs.webkit.org/show_bug.cgi?id=54724
> +
> +	   Set the end of the selection if the direction is left within an RTL
container, and likewise for the start.

I don't think there is sufficient explanation as to how incorrect it is.  You
should also explain what caused the issue and how you fixed it.  r- for
insufficient descriptions.  Also, since the bug title is really long, you might
want to split it into two lines.