[webkit-reviews] review granted: [Bug 42629] [Qt] Implement client based geolocation for qtport : [Attachment 82823] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42629: [Qt] Implement client based geolocation for qtport
https://bugs.webkit.org/show_bug.cgi?id=42629

Attachment 82823: patch
https://bugs.webkit.org/attachment.cgi?id=82823&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82823&action=review

> Source/WebKit/qt/ChangeLog:9
> +	   Implements client based geolocation for qtwebkit. New client based
geolocation contains permission API's as well
> +	   so removed the implementation from ChromeClientQt.cpp. 

Please try to keep these within 80 chars in the ChangeLogs

> Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp:63
> +void GeolocationClientQt::positionUpdated(const QGeoPositionInfo
&geoPosition)

wrong & alignment