[webkit-reviews] review denied: [Bug 54700] fix various bugs causing test-webkitpy to fail on win32 : [Attachment 82903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 20:44:13 PST 2011


Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54700: fix various bugs causing test-webkitpy to fail on win32
https://bugs.webkit.org/show_bug.cgi?id=54700

Attachment 82903: Patch
https://bugs.webkit.org/attachment.cgi?id=82903&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82903&action=review

> Tools/Scripts/webkitpy/common/net/testoutput.py:51
> +	   path = re.split(re.escape(os.path.sep), filename)

Can't you just do filename.split(os.path.sep)?

> Tools/Scripts/webkitpy/common/net/testoutput.py:57
> +	   path = re.split(re.escape(os.path.sep), filename)

ditto


More information about the webkit-reviews mailing list