[webkit-reviews] review denied: [Bug 54688] ThreadableLoaderClient needs willSendRequest method. : [Attachment 82861] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied  review:
Bug 54688: ThreadableLoaderClient needs willSendRequest method.
https://bugs.webkit.org/show_bug.cgi?id=54688

Attachment 82861: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=82861&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Good catch Alexey!

As Alexey gently pointed out, this simply doesn't work. willSendRequest may
modify the request (see
http://trac.webkit.org/browser/trunk/Source/WebCore/loader/SubresourceLoaderCli
ent.h), but all calls to the worker are async, so the callback to the worker
doesn't function correctly.

In fact, you can't do a sync call in that direction, so something else has to
be done for this case.