[webkit-reviews] review granted: [Bug 54652] REGRESSION (r78522): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_setup_environ_for_server_register_cygwin failing on Apple's Windows port : [Attachment 82905] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 54652: REGRESSION (r78522):
webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_setup_env
iron_for_server_register_cygwin failing on Apple's Windows port
https://bugs.webkit.org/show_bug.cgi?id=54652

Attachment 82905: Patch
https://bugs.webkit.org/attachment.cgi?id=82905&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82905&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py:102
> +    def baseline_path(self):
> +	   if self.version() == 'win7':
> +	       return self._webkit_baseline_path('chromium-win')
> +	   return self._webkit_baseline_path(self.name())

Why does win7 need a special case? Seems worth a comment.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:44
> +	       self.results_directory = '/'

What effect does this have? Can you explain in the ChangeLog?