[webkit-reviews] review granted: [Bug 54708] webkitpy.layout_tests.port.mock_drt_unittest fails on win32 : [Attachment 82894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 19:38:10 PST 2011


Adam Roben (aroben) <aroben at apple.com> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 54708: webkitpy.layout_tests.port.mock_drt_unittest fails on win32
https://bugs.webkit.org/show_bug.cgi?id=54708

Attachment 82894: Patch
https://bugs.webkit.org/attachment.cgi?id=82894&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82894&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:46
> +	   if sys.platform == 'win32':
> +	       return mock_drt.MockDRTPort(port_name='mock-chromium-win')

You could add a FIXME here referencing bug 48728 and a desire to test both
chromium-win and win.


More information about the webkit-reviews mailing list