[webkit-reviews] review granted: [Bug 54703] webkitpy.layout_tests.port.config_unittest fails on Win32 : [Attachment 82900] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 54703: webkitpy.layout_tests.port.config_unittest fails on Win32
https://bugs.webkit.org/show_bug.cgi?id=54703

Attachment 82900: Patch
https://bugs.webkit.org/attachment.cgi?id=82900&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review

> Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195
> +	   if sys.platform == 'win32':
> +	       os.chdir(os.environ['USERPROFILE'])
> +	   else:
> +	       os.chdir(os.environ['HOME'])

I wonder if we should come up with our own abstraction for this? Maybe not if
it's only needed by test code.