[webkit-reviews] review granted: [Bug 53940] Implement the OES_vertex_array_object WebGL extension : [Attachment 82854] Revised implementation of OES_vertex_array_object

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Ben Vanik <ben.vanik at gmail.com>'s
request for review:
Bug 53940: Implement the OES_vertex_array_object WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=53940

Attachment 82854: Revised implementation of OES_vertex_array_object
https://bugs.webkit.org/attachment.cgi?id=82854&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82854&action=review

Looks great. I'll help you land this by hand tomorrow morning so we can watch
the bots. One tiny naming convention issue; not necessary to upload a new patch
for it, but if you have time to that would be great.

> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:41
> +	   kVaoTypeDefault,
> +	   kVaoTypeUser,

WebKit style doesn't use the "k" for these, paradoxically -- so they should
just be VaoTypeDefault and VaoTypeUser.