[webkit-reviews] review requested: [Bug 54693] [EFL] Fix coding style errors in RenderThemeEfl.h : [Attachment 82874] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 54693: [EFL] Fix coding style errors in RenderThemeEfl.h
https://bugs.webkit.org/show_bug.cgi?id=54693

Attachment 82874: Patch
https://bugs.webkit.org/attachment.cgi?id=82874&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I make a patch for this. If parameter type represents parameter's meaning well,
I think we don't need to add parameter unnecessarily.
Other port add just parameter type to function definition. (See also
RenderThemeGtk.h, RenderThemeQt.h)

However, there are still style errors regarding underscore.

Source/WebCore/platform/efl/RenderThemeEfl.h:37:  Ecore_Evas is incorrectly
named. Don't use underscores in your identifier names.	[readability/naming]
[4]
Source/WebCore/platform/efl/RenderThemeEfl.h:38:  Evas_Object is incorrectly
named. Don't use underscores in your identifier names.	[readability/naming]
[4]

I don't know how to fix this errors yet.