[webkit-reviews] review denied: [Bug 54658] [gtk] Failing collinear arcTo canvas tests : [Attachment 82798] Add collinearity check

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 54658: [gtk] Failing collinear arcTo canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54658

Attachment 82798: Add collinearity check
https://bugs.webkit.org/attachment.cgi?id=82798&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82798&action=review

This is great! We want to make the if statement a little clearer below.

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:187
> +	   || !(p0.x() * (p1.y() - p2.y()) + p1.x() * (p2.y() - p0.y()) +
p2.x() * (p0.y() - p1.y()))) {

Please split out the area calculation to a static inline method called
something like areaOfTriangleFormedByPoints.