[webkit-reviews] review requested: [Bug 54621] [EFL] Remove proxy feature of soup when proxy is null : [Attachment 82869] Fixed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 17 15:21:48 PST 2011
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 54621: [EFL] Remove proxy feature of soup when proxy is null
https://bugs.webkit.org/show_bug.cgi?id=54621
Attachment 82869: Fixed Patch
https://bugs.webkit.org/attachment.cgi?id=82869&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
>> Please move "session" declaration line to withing the "if" block.
Do you mean that the session declaration need to be moved to if block ?
I add "return" to if block. How do you think about it ?
The session declaration should be declared regardless of proxy.
More information about the webkit-reviews
mailing list