[webkit-reviews] review denied: [Bug 34285] [Gtk] Password field doesn't get input method : [Attachment 82130] Allow input methods in password input elements, #2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 15:19:26 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 34285: [Gtk] Password field doesn't get input method
https://bugs.webkit.org/show_bug.cgi?id=34285

Attachment 82130: Allow input methods in password input elements, #2
https://bugs.webkit.org/attachment.cgi?id=82130&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82130&action=review

I believe that in Chromium, they only allow simple input method events.

> Source/WebCore/html/PasswordInputType.cpp:67
> +#if PLATFORM(MAC)
> +    // Platform convention is to disallow input methods for passwords.
> +    ASSERT_NOT_REACHED();
> +#endif

This seems wrong. Why should PLATFORM(MAC) ASSERT_NOT_REACHED() ?

> Source/WebCore/html/PasswordInputType.cpp:70
> +    return true;

If we going to do this, we probably only want to do it for PLATFORM(GTK).


More information about the webkit-reviews mailing list