[webkit-reviews] review requested: [Bug 48636] [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String : [Attachment 82840] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 12:03:42 PST 2011


qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 48636: [Qt] Mobile Devices should include Model and Firmware Version in
Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Attachment 82840: patch
https://bugs.webkit.org/attachment.cgi?id=82840&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
1. only keep model in user agent string, no hardware version.
2. remove duplicates ";" 
3. for linux:
   with qtmobility: "Mozilla/5.0 (X11; U; Linux; i686 Tower; en-US)
AppleWebKit/534.17 (KHTML, like Gecko) QtTestBrowser/0.1 Safari/534.17"
   without qtmobility: "Mozilla/5.0 (X11; U; Linux i686; en-US)
AppleWebKit/534.17 (KHTML, like Gecko) QtTestBrowser/0.1 Safari/534.17"
4. for symbian:
   with qtmobility: "Mozilla/5.0 (Symbian/3; U; N8-00; en-US)
AppleWebKit/534.17 (KHTML, like Gecko) QtTestBrowser/0.1 Safari/534.3"
   without qtmobility: "Mozilla/5.0 (Symbian/3; U; en-US) AppleWebKit/534.17
(KHTML, like Gecko) QtTestBrowser/0.1 Safari/534.3"


More information about the webkit-reviews mailing list