[webkit-reviews] review granted: [Bug 54501] WebKit2: Need a way to manage the WebCore Cache : [Attachment 82762] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 54501: WebKit2: Need a way to manage the WebCore Cache
https://bugs.webkit.org/show_bug.cgi?id=54501

Attachment 82762: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=82762&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82762&action=review

> Source/WebKit2/Shared/SecurityOriginData.h:43
> +    // FIXME: We should be sending more state across the wire than just the
protocol,
> +    // host, and port.

Could you file a bug for this?

> Source/WebKit2/Shared/WebSecurityOrigin.h:55
> +    static PassRefPtr<WebSecurityOrigin> createFromString(const String&
string)

Is this from an older version of the patch and is no longer needed?

> Source/WebKit2/UIProcess/API/C/WKAPICast.h:99
> -inline CacheModel toCacheModel(WKCacheModel wkCacheModel)
> +inline CacheModel toCacheModel(WKCacheModel WKCacheModel)
>  {
> -    switch (wkCacheModel) {
> +    switch (WKCacheModel) {

Surprised this compiled.  Please remove this change.