[webkit-reviews] review denied: [Bug 54671] Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit : [Attachment 82829] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 54671: Web Inspector: provide a button to expand inspector toolbar when not
all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671

Attachment 82829: patch
https://bugs.webkit.org/attachment.cgi?id=82829&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82829&action=review

> Source/WebCore/inspector/front-end/ToolbarDropdown.js:37
> +    var toolbarStyle = getComputedStyle(this._toolbar);

You should make original style applicable to the new elements. Also won't work
for the Mac port.

> Source/WebCore/inspector/front-end/ToolbarDropdown.js:99
> +    if (!WebInspector.toolbarDropdown) {

Could you keep it as a local state?

> Source/WebCore/inspector/front-end/inspector.css:184
> +    background-image: -webkit-gradient(linear, left top, left bottom,
from(rgba(251, 251, 251, 0.9)), to(rgba(231, 231, 231, 0.9)));

Should it be themed? toolbar-label ?