[webkit-reviews] review granted: [Bug 54669] IndexedDB: Populate indexes created for object stores with data : [Attachment 82821] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 54669: IndexedDB: Populate indexes created for object stores with data
https://bugs.webkit.org/show_bug.cgi?id=54669

Attachment 82821: Patch
https://bugs.webkit.org/attachment.cgi?id=82821&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82821&action=review

great stuff!

> Source/WebCore/storage/IDBIndexBackendImpl.h:-32
> -

Isnt  this space typical?

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:328
> +	   if (!it->second->hasValidId())

Probably worth a comment