[webkit-reviews] review canceled: [Bug 42629] [Qt] Implement client based geolocation for qtport : [Attachment 82654] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 09:48:30 PST 2011


Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has canceled Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42629: [Qt] Implement client based geolocation for qtport
https://bugs.webkit.org/show_bug.cgi?id=42629

Attachment 82654: patch
https://bugs.webkit.org/attachment.cgi?id=82654&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
Thanks for review Kenneth. Updated patch as per comment #25

Now QGeoPositionInfoSource is created only when location request is made, 
1) Instance of location service isnt created if the page doesn't need it. 2) If
a page fails to get a instance of location service, it retries on next request.


More information about the webkit-reviews mailing list