[webkit-reviews] review denied: [Bug 54560] Drop the language tag part from the User Agent string : [Attachment 82813] first try

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 54560: Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

Attachment 82813: first try
https://bugs.webkit.org/attachment.cgi?id=82813&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82813&action=review

What exactly does this change affect? Is it all of navigator.userAgent,
navigator.appVersion, and HTTP User-Agent header field? Can you add tests for
all of these?

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:-124
> -    ua += "; ";
> -    ua += defaultLanguage(); // Localization information

There is likely an #include to remove in this file.

> Source/WebKit/efl/ewk/ewk_settings.cpp:326
> -    WTF::String static_ua = makeString("Mozilla/5.0 (",
_ewk_settings_webkit_platform_get(), "; U; ",
_ewk_settings_webkit_os_version_get(), "; ", WebCore::defaultLanguage(), ")
AppleWebKit/", ua_version) + makeString(" (KHTML, like Gecko) Version/5.0
Safari/", ua_version);
> +    WTF::String static_ua = makeString("Mozilla/5.0 (",
_ewk_settings_webkit_platform_get(), "; U; ",
_ewk_settings_webkit_os_version_get(), ") AppleWebKit/", ua_version) +
makeString(" (KHTML, like Gecko) Version/5.0 Safari/", ua_version);

Ditto.

> Source/WebKit/mac/WebView/WebView.mm:-551
> -    NSString *language = [NSUserDefaults _webkit_preferredLanguageCode];

Ditto.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:-96
>      String language = defaultLanguage();
>  
>      if (applicationNameForUserAgent.isEmpty())
> -	   return makeString("Mozilla/5.0 (Macintosh; U; " PROCESSOR " Mac OS X
", osVersion, "; ", language, ") AppleWebKit/", webKitVersion, " (KHTML, like
Gecko)");
> -    return makeString("Mozilla/5.0 (Macintosh; U; " PROCESSOR " Mac OS X ",
osVersion, "; ", language, ") AppleWebKit/", webKitVersion, " (KHTML, like
Gecko) ", applicationNameForUserAgent);

This code won't even compile as is, due to unused variable warning.