[webkit-reviews] review denied: [Bug 54641] [Qt] ImageDiff sometimes hangs : [Attachment 82816] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 17 08:59:08 PST 2011
Andreas Kling <kling at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 54641: [Qt] ImageDiff sometimes hangs
https://bugs.webkit.org/show_bug.cgi?id=54641
Attachment 82816: proposed fix
https://bugs.webkit.org/attachment.cgi?id=82816&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82816&action=review
> Tools/DumpRenderTree/qt/ImageDiff.cpp:146
> + actualImage = QImage();
> + baselineImage = QImage();
This should be below the next } so they get cleared if one of them isNull(),
too.
More information about the webkit-reviews
mailing list