[webkit-reviews] review denied: [Bug 54569] Potential Null pointer dereference checks : [Attachment 82810] Patch for potential null pointer dereferences

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 08:27:21 PST 2011


Andreas Kling <kling at webkit.org> has denied sangeetha.sugavanam at nokia.com's
request for review:
Bug 54569: Potential Null pointer dereference checks
https://bugs.webkit.org/show_bug.cgi?id=54569

Attachment 82810: Patch for potential null pointer dereferences
https://bugs.webkit.org/attachment.cgi?id=82810&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
These are two completely unrelated changes and should not be done in the same
patch.

You need to explain in the ChangeLog what you are changing and why. And if
possible, a layout test should be added that triggers a bug without the change,
otherwise please explain why it is not testable.


More information about the webkit-reviews mailing list