[webkit-reviews] review granted: [Bug 54595] new-run-webkit-tests: --dry-run hangs with --worker-model=processes : [Attachment 82711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 00:01:14 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54595: new-run-webkit-tests: --dry-run hangs with --worker-model=processes
https://bugs.webkit.org/show_bug.cgi?id=54595

Attachment 82711: Patch
https://bugs.webkit.org/attachment.cgi?id=82711&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82711&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:122
> +	   keyboard_interrupted = False
> +	   interrupted = False
> +	   thread_timings = []

Nit: I prefer variables being defined as close to the code they're used as
possible. So, I'd move these down to be around line 131 instead.


More information about the webkit-reviews mailing list