[webkit-reviews] review granted: [Bug 54511] Allow acceleratesDrawing for WebKit2 : [Attachment 82736] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 54511: Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511

Attachment 82736: Patch
https://bugs.webkit.org/attachment.cgi?id=82736&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82736&action=review

r=me bug DrawingAreaImpl::exitAcceleratedCompositing() needs fixing.

> Source/WebCore/ChangeLog:12
> +	   * WebCore.exp.in:Plumb through acceleratesDrawing
> +	   * page/Settings.cpp:Plumb through acceleratesDrawing
> +	   * page/Settings.h: Plumb through acceleratesDrawing

Be consistent about putting a space after the colon.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:316
> +    m_webPage->corePage()->settings()->acceleratedDrawingEnabled();

This isn't doing anything.