[webkit-reviews] review requested: [Bug 53705] Viewport parsing no longer accepts "1.0; " value as valid. : [Attachment 82738] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 16 19:20:22 PST 2011
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 53705: Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Attachment 82738: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=82738&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This implements the fix, as well as improves the console error/warning messages
around this situation. I don't have a Qt/Efl/Gtk machine to run the test, but I
suspect this may slightly change the results of some tests. I also specifically
added a test for this case. I'd hate to just land this and check the watch the
bot
for changes. Anyone care to run this on their port? The mac port skips
fast/viewport tests.
Also, see the following for even better warning/error messages: (requires this
patch)
<http://webkit.org/b/53707> Viewport Warning/Error Messages Are Now Inaccurate
More information about the webkit-reviews
mailing list