[webkit-reviews] review denied: [Bug 54313] Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient. : [Attachment 82724] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 16 17:13:05 PST 2011


David Levin <levin at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 54313: Need didReceiveCachedMetadata, and finishTime for didFinishLoading
exposed in ThreadableLoaderClient.
https://bugs.webkit.org/show_bug.cgi?id=54313

Attachment 82724: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=82724&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82724&action=review

> Source/WebCore/workers/WorkerScriptLoader.cpp:137
> +void WorkerScriptLoader::didFinishLoading(unsigned long identifier, double
finishTime)

omit "finishTime" since it isn't used. (As is, this will fail the compile stage
on OSX.)


More information about the webkit-reviews mailing list