[webkit-reviews] review granted: [Bug 54023] [chromium] Three texture-related webgl tests failing in DEBUG due to skia change : [Attachment 82622] call non-asserting version of SkPackARGB32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 16 12:29:55 PST 2011


Kenneth Russell <kbr at google.com> has granted Mike Reed <reed at google.com>'s
request for review:
Bug 54023: [chromium] Three texture-related webgl tests failing in DEBUG due to
skia change
https://bugs.webkit.org/show_bug.cgi?id=54023

Attachment 82622: call non-asserting version of SkPackARGB32
https://bugs.webkit.org/attachment.cgi?id=82622&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine. I patched my workspace locally to still call SkPackARGB32 if
m_premultiplyAlpha is true, but it's another if-test in an inner loop that
isn't really necessary. r=me


More information about the webkit-reviews mailing list