[webkit-reviews] review denied: [Bug 54524] Allow JSObject to fully utilize cell's capacity for inline storage. : [Attachment 82592] The patch, this shows a small sunspider regression, but a similar v8 progression - a wash overall.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 54524: Allow JSObject to fully utilize cell's capacity for inline storage.
https://bugs.webkit.org/show_bug.cgi?id=54524

Attachment 82592: The patch, this shows a small sunspider regression, but a
similar v8 progression - a wash overall.
https://bugs.webkit.org/attachment.cgi?id=82592&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82592&action=review

r=me if you fix the build.

> Source/JavaScriptCore/ChangeLog:17
> +	   and only allows construction through JSFinalObject::create().

I think you should mention the reason for this change -- now all objects have a
direct pointer to their storage, and lea shenanigans are not required.

> Source/JavaScriptCore/runtime/JSObject.h:298
> +COMPILE_ASSERT((JSFinalObject_inlineStorageCapacity >=
JSNonFinalObject_inlineStorageCapacity),
vanilla_storage_is_at_least_as_large_as_non_vanilla);

s/vanilla/final/

> Source/JavaScriptCore/runtime/JSTypeInfo.h:73
> +	   unsigned isVanilla() const { return m_flags2 && (IsJSFinalObject >>
8); }

s/Vanilla/Final/