[webkit-reviews] review denied: [Bug 50916] Add support for dir=auto : [Attachment 81841] Patch.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 50916: Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916

Attachment 81841: Patch.
https://bugs.webkit.org/attachment.cgi?id=81841&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81841&action=review

Much better in HTMLElement.  Just one concern:

> Source/WebCore/html/HTMLElement.cpp:1005
> +    if (childCountDelta > 0) {
> +	   Node* node = beforeChange ? beforeChange->traverseNextSibling() : 0;

> +	   for (int counter = 0; node && counter < childCountDelta; counter++,
node = node->traverseNextSibling()) {
> +	       if (node->isElementNode() &&
toElement(node)->hasAttribute(dirAttr))
> +		   continue;
> +
> +	       setHasDirAutoFlagRecursively(node, false);
> +	   }
> +    }

This code concerns me.	It seems like it's going to run on every
childrenChanged call?  This seems like an obvious performance hit.  Does this
code really have to run all the time, or did you mean to put it below the if
check?