[webkit-reviews] review denied: [Bug 17425] Eliminate DeprecatedPtrList : [Attachment 82644] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 17425: Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425

Attachment 82644: Patch
https://bugs.webkit.org/attachment.cgi?id=82644&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You could have a Vector of OwnPtrs, and then you don't have to walk the list
deleting everything.

I still think it's better if you're making this conversion to move to a
ListHashSet instead though.  I'm not quite sure if ListHashSet has everything
you need, since you have to construct the hash key by using the RenderObject*
rather than the FloatingObject*, but then you'd be fixing the performance
problem with large float lists at the same time.

It just feels strange to me to convert to another list data structure when we
know that a list is not what we want to stick with long-term.