[webkit-reviews] review granted: [Bug 54457] IndexedDB: Inject auto increment keys via key path on insertion : [Attachment 82620] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 54457: IndexedDB: Inject auto increment keys via key path on insertion
https://bugs.webkit.org/show_bug.cgi?id=54457

Attachment 82620: Patch
https://bugs.webkit.org/attachment.cgi?id=82620&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82620&action=review

r=me

> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:71
> +    if (object->Has(indexOrName))

Simply assert?

> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:89
> +bool set(v8::Handle<v8::Value>& object, const IDBKeyPathElement&
keyPathElement, const v8::Handle<v8::Value>& v8Value)

make the param names and ordering consistent between these two?