[webkit-reviews] review requested: [Bug 25831] [GTK] events missing when a document is (re)loaded : [Attachment 82645] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25831: [GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Attachment 82645: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=82645&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #29)
> Reopening as per rollout done through bug 54295

Attaching new patch, which does not interfere with other tests as it was
pointed out in comment 28.

Seems like we can't call to gtk_widget_get_accessible() from
notifyAccessibilityStatus() in FrameLoaderClientGtk.cpp, as that will call
AXObjectCache::rootObject() which will call getOrCreate() over
m_document->view, which by that time might be not ready.

I worked around this by directly calling to getOrCreate over the
contentRenderer for the frame currently in use, which returned the valid
AtkObject as well (and proof for this is that the returned object implements
the AtkDocument interface which only happens for that single object of
interest).

Hence, eagerly asking for review :-)