[webkit-reviews] review granted: [Bug 54537] [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader : [Attachment 82604] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 54537: [Gtk] Add support for
layoutTestController.setWillSendRequestClearHeader
https://bugs.webkit.org/show_bug.cgi?id=54537

Attachment 82604: Patch
https://bugs.webkit.org/attachment.cgi?id=82604&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review

Great stuff. Please consider the following changes befor committing.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:95
> +    GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal);

I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're
already converting to String below so you can just reuse that. That will allow
you to remove a few lines below.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1015
> +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*,
WebKitWebResource* resource, WebKitNetworkRequest* request,
WebKitNetworkResponse* redirectResponse)

You can remove the "resource' and "redirectResponse" paramter names.