[webkit-reviews] review denied: [Bug 54313] Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient. : [Attachment 82584] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 16 07:21:27 PST 2011
David Levin <levin at chromium.org> has denied review:
Bug 54313: Need didReceiveCachedMetadata, and finishTime for didFinishLoading
exposed in ThreadableLoaderClient.
https://bugs.webkit.org/show_bug.cgi?id=54313
Attachment 82584: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=82584&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Looks like this breaks a layout test. (If you need to run that test in
chromium, it is in ui_tests.)
Please consider changing the ChangeLog "ThreadableLoaderClient doesn't support
WebURLLoader usage" to what I made the bug title.
Of course, your formulation is the answer to "Why?" which is nice but I think
"What?" would be better for this case.
More information about the webkit-reviews
mailing list