[webkit-reviews] review denied: [Bug 54544] Web Inspector: show all inlined scripts from single document in the same source frame : [Attachment 82611] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 54544: Web Inspector: show all inlined scripts from single document in the
same source frame
https://bugs.webkit.org/show_bug.cgi?id=54544

Attachment 82611: Patch.
https://bugs.webkit.org/attachment.cgi?id=82611&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82611&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:264
> +	   var sourceName = script.sourceURL || script.sourceID;

You are passing sourceID while _recreateSourceFrame uses it for lookup in
_urlToSource... These two types of ids shouldn't be mixed.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:531
> +	   var isScript = !script.lineOffset && !script.columnOffset;

Will this code work correctly with JSC when columnOffset is always 0 and
lineOffset may well be 0 for inline script.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1080
> +	   var lineNumber = 0, columnNumber = 0;

Each statement should go on a separate line.