[webkit-reviews] review granted: [Bug 53717] REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate : [Attachment 82566] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 53717: REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't
animate
https://bugs.webkit.org/show_bug.cgi?id=53717

Attachment 82566: Patch
https://bugs.webkit.org/attachment.cgi?id=82566&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82566&action=review

I believe this change is correct.  I don't really have an opinion on the
comment.

>> Source/WebCore/platform/KURL.cpp:349
>> +	// Browsers ignore leading/trailing whitespace and control
>> +	// characters from URLs.  Note that c is an *unsigned* char here
>> +	// so this comparison should only catch control characters.
> 
> Is this really worth explaining in a comment?

Most of the rest of KURL uses plain "char", which can be subtly confusing.