[webkit-reviews] review denied: [Bug 54517] Ensure loading has stopped in HistoryController::goToItem : [Attachment 82565] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Charles Reis
<creis at chromium.org>'s request for review:
Bug 54517: Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Attachment 82565: Patch
https://bugs.webkit.org/attachment.cgi?id=82565&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82565&action=review

> Source/WebCore/loader/HistoryController.cpp:225
> +    ASSERT(!m_frame->loader()->isLoading());

so i think this assertion will fail when goToItem is called to just jump to a
different reference fragment.