[webkit-reviews] review denied: [Bug 54511] Allow acceleratesDrawing for WebKit2 : [Attachment 82552] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 54511: Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511

Attachment 82552: Patch
https://bugs.webkit.org/attachment.cgi?id=82552&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82552&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests. Can't really test this.

Really, or not at all?

> Source/WebCore/ChangeLog:13
> +	   ^^ plumb through acceleratesDrawing

Don't use ^^, and use Sentence case.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1295
> -	   return canvas->renderingContext() &&
canvas->renderingContext()->isAccelerated();
> +	    return canvas->renderingContext() &&
canvas->renderingContext()->isAccelerated();

Spurious whitespace change here.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:294
> +    if (graphicsLayer)
> +	   m_layerTreeHost->setRootCompositingLayer(graphicsLayer);

You can remove this change now.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:312
> +    if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled())
> +	   return;

This is a bit hacky; we should clean up this code.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1366
> +    settings->setAcceleratedDrawingEnabled(store.getBoolValueForKey(false));


Why the store.getBoolValueForKey(false)?

> Source/WebKit/mac/WebView/WebPreferences.mm:361
> +	   [NSNumber numberWithBool:YES], 
WebKitAcceleratedDrawingEnabledPreferenceKey,

I think it should default to off.