[webkit-reviews] review denied: [Bug 54355] Let the parser yield for layout before running scripts : [Attachment 82539] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Tony Gentilcore <tonyg at chromium.org>'s
request for review:
Bug 54355: Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355

Attachment 82539: Patch
https://bugs.webkit.org/attachment.cgi?id=82539&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82539&action=review

Lets talk about this on IRC.  I like the idea, but this is scary stuff and I am
not convinced this added complication is all necessary/correct.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:201
> +    ASSERT(isWaitingForScripts());

It's unclear to me what the differnece between isWaitingForScripts and isPaused
is?

> Source/WebCore/html/parser/HTMLParserScheduler.cpp:97
> +bool HTMLParserScheduler::shouldRunScriptNow()

Seems like we could come up with a better name here.

Also, its strange that this does the chunk timer stuff, especially given the
name.