[webkit-reviews] review denied: [Bug 54497] [chromium] Canvas-2D-GPU fails on clearRect() w/identity transform and non-full-canvas rectangle : [Attachment 82523] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 54497: [chromium] Canvas-2D-GPU fails on clearRect() w/identity transform
and non-full-canvas rectangle
https://bugs.webkit.org/show_bug.cgi?id=54497

Attachment 82523: Patch
https://bugs.webkit.org/attachment.cgi?id=82523&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82523&action=review

R- for the changelog, but code looks good. Is there a test_expectations.txt
line we could flip for this test?

> Source/WebCore/ChangeLog:8
> +	   When doing GPU-Canvas2D clearRect() using the fast path (glClear()),

> +	   we were not correctly converting from canvas to screen coordinates. 

> +	   Fixed by inverting the rectangle in Y, and changing
> +	   SharedGraphicsContext3D::scissor to take glScissor-like parameters.

need a link to the bug in the ChangeLog