[webkit-reviews] review granted: [Bug 53281] To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size : [Attachment 80810] patch v3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ian Henderson <ianh at apple.com>'s
request for review:
Bug 53281: To determine image properties, CG allocates memory which isn't
included in CachedImage's decoded size
https://bugs.webkit.org/show_bug.cgi?id=53281

Attachment 80810: patch v3
https://bugs.webkit.org/attachment.cgi?id=80810&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80810&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:163
> +#ifndef NDEBUG
> +    bool overflow = updatedSize > m_decodedPropertiesSize && deltaBytes < 0;

> +    bool underflow = updatedSize < m_decodedPropertiesSize && deltaBytes >
0;
> +    ASSERT(!overflow && !underflow);
> +#endif

I know I raised the possibility of overflow. But I don’t think an assertion
really helps much. The worry about overflow is it actually happening in the
field, not happening on a debug build.