[webkit-reviews] review granted: [Bug 54168] Move WTF_USE_CFNETWORK to Platform.h : [Attachment 81925] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 54168: Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168

Attachment 81925: Patch
https://bugs.webkit.org/attachment.cgi?id=81925&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81925&action=review

r=me with the fix to provide a default for WTF_USE_CFNETWORK.

> Source/JavaScriptCore/wtf/Platform.h:684
> +#define WTF_USE_CFNETWORK 1

You need to add a section closer to the end of Platform.h that provides a
default:

#if !defined(WTF_USE_CFNETWORK)
#define WTF_USE_CFNETWORK 0
#endif

You might want to move it close to this line just for proximity's sake:

/* Set up a define for a common error that is intended to cause a build error
-- thus the space after Error. */
#define WTF_PLATFORM_CFNETWORK Error USE_macro_should_be_used_with_CFNETWORK