[webkit-reviews] review granted: [Bug 54482] Moved MarkedBlock data members to the head of the block : [Attachment 82498] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 15 12:16:39 PST 2011
Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 54482: Moved MarkedBlock data members to the head of the block
https://bugs.webkit.org/show_bug.cgi?id=54482
Attachment 82498: Patch
https://bugs.webkit.org/attachment.cgi?id=82498&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82498&action=review
Change seems fine. Could you please take a little time out and make the
constants use normal style instead of MACRO_STYLE? Then the style bot would
like you better.
> Source/JavaScriptCore/runtime/MarkedBlock.h:38
> + template <size_t divisor> inline size_t roundUpToMultipleOf(size_t x)
Normally we don’t put a space between template and the "<" by analogy with the
function name and "(".
More information about the webkit-reviews
mailing list