[webkit-reviews] review denied: [Bug 54405] Fix coverity REVERSE_INULL errors : [Attachment 82490] patch fixing the coverity reverse_inull errors in webkit.org

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 12:13:47 PST 2011


Darin Adler <darin at apple.com> has denied sangeetha.sugavanam at nokia.com's
request for review:
Bug 54405: Fix coverity REVERSE_INULL errors
https://bugs.webkit.org/show_bug.cgi?id=54405

Attachment 82490: patch fixing the coverity reverse_inull errors in webkit.org 
https://bugs.webkit.org/attachment.cgi?id=82490&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Style is wrong here.

And we won’t just add null checks without test cases. We want to cover the
cases where these are null, not just take the tool’s word for it. The tool
helped us discover the missing null checks. Now human beings have to actually
create test cases.

Also, patches need to include the change log entries in them. Separately
posting a copy of the entire change log is not acceptable.


More information about the webkit-reviews mailing list