[webkit-reviews] review denied: [Bug 54436] controls are rendered below canvas in mediaDocument instead of overlapping : [Attachment 82416] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 15 11:28:50 PST 2011
David Levin <levin at chromium.org> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 54436: controls are rendered below canvas in mediaDocument instead of
overlapping
https://bugs.webkit.org/show_bug.cgi?id=54436
Attachment 82416: Patch
https://bugs.webkit.org/attachment.cgi?id=82416&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82416&action=review
> Source/WebCore/ChangeLog:15
> + expected spot (0,208) instead of below the canvas (0,240). Any
This part about "any" doesn't belong in the ChangeLog but would be fine in the
bug.
> Source/WebCore/ChangeLog:18
> + output but not on a PNG?)
Not that I know of. I know that you can dump markup but I don't think that
would suit your needs.
btw, I strongly suspect that these results are chromium specific. So
LayoutTests/media/video-controls-in-media-document-expected.txt may not be the
best place for them.
More information about the webkit-reviews
mailing list